On 2/20/24 16:11, Andy Shevchenko wrote: > On Tue, Feb 20, 2024 at 11:43:39AM +0200, Dumitru Ceclan wrote: >> Add optional irq_num attribute to ad_sigma_delta_info structure for >> selecting the used interrupt line for adc's conversion completion. > > ... > >> + if (!info->irq_num) >> + sigma_delta->irq_num = spi->irq; >> + else >> + sigma_delta->irq_num = info->irq_num; > > Why not positive check? > Considered that selecting spi->irq is usually the default case, so it should be the first branch