On Tue, Feb 20 2024 at 11:37, Anup Patel wrote:
> +#ifdef CONFIG_SMP
> +static void imsic_msi_update_msg(struct irq_data *d, struct imsic_vector *vec)
> +{
> + struct msi_msg msg[2] = { [1] = { }, };
That's a weird initializer and why do you need an array here?
struct msi_msg msg = { };
Should be sufficient, no?
> +
> + imsic_irq_compose_vector_msg(vec, msg);
> + irq_data_get_irq_chip(d)->irq_write_msi_msg(d, msg);
> +}
> +static int imsic_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
> + unsigned int nr_irqs, void *args)
> +{
> + struct imsic_vector *vec;
> +
> + /* Legacy-MSI or multi-MSI not supported yet. */
Coming back to my earlier question:
>> What's legacy MSI in that context?
>
> The legacy-MSI is the MSI support in PCI v2.2 where
> number of MSIs allocated by device were either 1, 2, 4,
> 8, 16, or 32 and the data written is <data_word> + <irqnum>.
You talk about PCI/MSI, where more than one vector is named
multi-MSI. Contrary to the modern v3.0 variant which is PCI/MSI-X.
So this should be "Multi-MSI is not supported yet", no?
> + if (nr_irqs > 1)
> + return -ENOTSUPP;
> +
> + vec = imsic_vector_alloc(virq, cpu_online_mask);
> + if (!vec)
> + return -ENOSPC;
> +
> + irq_domain_set_info(domain, virq, virq,
> + &imsic_irq_base_chip, vec,
> + handle_simple_irq, NULL, NULL);
Please utilize the 100 characters.
> + irq_set_noprobe(virq);
> + irq_set_affinity(virq, cpu_online_mask);
> +
> + return 0;
> +}
Thanks,
tglx
