On 20/02/2024 10:11, Jingyi Wang wrote: > Hi Krzysztof, > > On 2/5/2024 8:35 PM, Krzysztof Kozlowski wrote: >> On 05/02/2024 12:57, Jingyi Wang wrote: >>> Introduce aim500 board dtsi. >>> >>> AIM500 Series is a highly optimized family of modules designed to >>> support AIoT and Generative AI applications based on sm8650p with >>> PMIC and bluetooth functions etc. >>> >>> Co-developed-by: Tingwei Zhang <quic_tingweiz@xxxxxxxxxxx> >>> Signed-off-by: Tingwei Zhang <quic_tingweiz@xxxxxxxxxxx> >>> Signed-off-by: Jingyi Wang <quic_jingyw@xxxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi | 409 +++++++++++++++++++ >>> 1 file changed, 409 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi b/arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi >>> new file mode 100644 >>> index 000000000000..cb857da8653b >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/sm8650p-aim500.dtsi >>> @@ -0,0 +1,409 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> + >>> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> >>> +#include "sm8650p.dtsi" >>> +#include "pm8550.dtsi" >>> +#include "pm8550b.dtsi" >>> +#define PMK8550VE_SID 8 >>> +#include "pm8550ve.dtsi" >>> +#include "pm8550vs.dtsi" >>> +#include "pmk8550.dtsi" >>> + >>> +/ { >>> + aliases { >>> + serial1 = &uart14; >>> + }; >>> + >>> + vph_pwr: vph-pwr-regulator { }; >> >> What is this? Why is it needed? >> >> >> Best regards, >> Krzysztof >> > vph_pwr is the power supply which differs from board design, it is defined in sm8650p-aim500-aiot.dts, > and it is used in the sm8650p-aim500.dts for regulator supply, so we leave the node here. How an empty, unused node is a power supply? Best regards, Krzysztof