On Mon, 19 Feb 2024 at 14:23, Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > > On Mon, Feb 19, 2024 at 11:26 AM Dmitry Baryshkov > <dmitry.baryshkov@xxxxxxxxxx> wrote: > > > > [snip] > > > > >>>> > > > >>>> For WCN7850 we hide the existence of the PMU as modeling it is simply not > > > >>>> necessary. The BT and WLAN devices on the device-tree are represented as > > > >>>> consuming the inputs (relevant to the functionality of each) of the PMU > > > >>>> directly. > > > >>> > > > >>> We are describing the hardware. From the hardware point of view, there > > > >>> is a PMU. I think at some point we would really like to describe all > > > >>> Qualcomm/Atheros WiFI+BT units using this PMU approach, including the > > > >>> older ath10k units present on RB3 (WCN3990) and db820c (QCA6174). > > > >> > > > >> While I agree with older WiFi+BT units, I don't think it's needed for > > > >> WCN7850 since BT+WiFi are now designed to be fully independent and PMU is > > > >> transparent. > > > > > > > > I don't see any significant difference between WCN6750/WCN6855 and > > > > WCN7850 from the PMU / power up point of view. Could you please point > > > > me to the difference? > > > > > > > > > > The WCN7850 datasheet clearly states there's not contraint on the WLAN_EN > > > and BT_EN ordering and the only requirement is to have all input regulators > > > up before pulling up WLAN_EN and/or BT_EN. > > > > > > This makes the PMU transparent and BT and WLAN can be described as independent. > > > > From the hardware perspective, there is a PMU. It has several LDOs. So > > the device tree should have the same style as the previous > > generations. > > > > My thinking was this: yes, there is a PMU but describing it has no > benefit (unlike QCA6x90). If we do describe, then we'll end up having > to use pwrseq here despite it not being needed because now we won't be > able to just get regulators from WLAN/BT drivers directly. > > So I also vote for keeping it this way. Let's go into the package > detail only if it's required. The WiFi / BT parts are not powered up by the board regulators. They are powered up by the PSU. So we are not describing it in the accurate way. Moreover, I think we definitely want to move BT driver to use only the pwrseq power up method. Doing it in the other way results in the code duplication and possible issues because of the regulator / pwrseq taking different code paths. -- With best wishes Dmitry
