On 18/02/2024 09:21, Yang Xiwen wrote: > On 2/18/2024 4:03 PM, kernel test robot wrote: >> Hi Yang, >> >> kernel test robot noticed the following build errors: >> >> [auto build test ERROR on 8d3dea210042f54b952b481838c1e7dfc4ec751d] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Yang-Xiwen-via-B4-Relay/mmc-dw_mmc-add-support-for-hi3798mv200/20240216-014744 >> base: 8d3dea210042f54b952b481838c1e7dfc4ec751d >> patch link: https://lore.kernel.org/r/20240216-b4-mmc-hi3798mv200-v1-1-7d46db845ae6%40outlook.com >> patch subject: [PATCH 1/3] mmc: dw_mmc: add support for hi3798mv200 >> config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20240218/202402181540.H4Ose96P-lkp@xxxxxxxxx/config) >> compiler: hppa-linux-gcc (GCC) 13.2.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240218/202402181540.H4Ose96P-lkp@xxxxxxxxx/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot <lkp@xxxxxxxxx> >> | Closes: https://lore.kernel.org/oe-kbuild-all/202402181540.H4Ose96P-lkp@xxxxxxxxx/ >> >> All errors (new ones prefixed by >>): >> >> drivers/mmc/host/dw_mmc-hi3798mv200.c: In function 'dw_mci_hi3798mv200_init': >>>> drivers/mmc/host/dw_mmc-hi3798mv200.c:178:36: error: passing argument 1 of 'mmc_of_parse_clk_phase' from incompatible pointer type [-Werror=incompatible-pointer-types] >> 178 | mmc_of_parse_clk_phase(host->dev, &priv->phase_map); >> | ~~~~^~~~~ >> | | >> | struct device * >> In file included from drivers/mmc/host/dw_mmc-hi3798mv200.c:11: >> include/linux/mmc/host.h:542:46: note: expected 'struct mmc_host *' but argument is of type 'struct device *' >> 542 | void mmc_of_parse_clk_phase(struct mmc_host *host, >> | ~~~~~~~~~~~~~~~~~^~~~ >> cc1: some warnings being treated as errors >> >> >> vim +/mmc_of_parse_clk_phase +178 drivers/mmc/host/dw_mmc-hi3798mv200.c >> >> 168 >> 169 static int dw_mci_hi3798mv200_init(struct dw_mci *host) >> 170 { >> 171 struct dw_mci_hi3798mv200_priv *priv; >> 172 struct device_node *np = host->dev->of_node; >> 173 >> 174 priv = devm_kzalloc(host->dev, sizeof(*priv), GFP_KERNEL); >> 175 if (!priv) >> 176 return -ENOMEM; >> 177 >> > 178 mmc_of_parse_clk_phase(host->dev, &priv->phase_map); > > Please note that this patch is depending on another patch[1]. > > [1]: > https://lore.kernel.org/linux-mmc/ae876e697ba16ba2925ec217c6b4e3d8ffea4ab3.camel@xxxxxxxxxxxxxxxxxxxx/T/#t > You did not provide any links to dependencies in cover letter nor in patch changelog. You included on purpose, which is nice and correct, the base commit: base-commit: 8d3dea210042f54b952b481838c1e7dfc4ec751d which does not include above commit apparently. How anyone can guess it and test your patches? Please send with proper dependencies marked. Best regards, Krzysztof