On 13/02/2024 15:58, Marc Gonzalez wrote: > On 13/02/2024 14:51, Rob Herring wrote: > >> On Mon, Feb 12, 2024 at 06:53:01PM +0100, Marc Gonzalez wrote: >> >>> From: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >>> >>> Add support for two variants of the fbx8am board. >>> >>> Signed-off-by: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >>> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/amlogic/Makefile | 7 +++++++ >>> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am-brcm.dtso | 35 ++++++++++++++++++++++++++++++++++ >>> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am-realtek.dtso | 25 ++++++++++++++++++++++++ >>> 3 files changed, 67 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile >>> index e9baa2cf02273..2fd7c7a18126f 100644 >>> --- a/arch/arm64/boot/dts/amlogic/Makefile >>> +++ b/arch/arm64/boot/dts/amlogic/Makefile >>> @@ -81,3 +81,10 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb >>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb >>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air-gbit.dtb >>> dtb-$(CONFIG_ARCH_MESON) += meson-sm1-x96-air.dtb >>> + >>> +# Overlays >>> +dtb-$(CONFIG_ARCH_MESON) += meson-g12a-fbx8am-brcm.dtbo >>> +dtb-$(CONFIG_ARCH_MESON) += meson-g12a-fbx8am-realtek.dtbo >>> + >>> +# Enable support for DT overlays >>> +DTC_FLAGS_meson-g12a-fbx8am += -@ >> >> Overlays need to be applied to something in the kernel at build time. >> Applying is done the same way as composing object files for modules. > > Hello Rob, > > I don't quite understand your remark. > I copied what other platforms do: > > $ git grep DTC_FLAGS_ arch/arm64/boot/dts/ You copied only parts of the solutions... > arch/arm64/boot/dts/amlogic/Makefile:DTC_FLAGS_meson-g12a-fbx8am += -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra210-p2371-2180 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra210-p3450-0000 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra186-p2771-0000 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra186-p3509-0000+p3636-0001 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra194-p2972-0000 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra194-p3509-0000+p3668-0000 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra194-p3509-0000+p3668-0001 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra234-p3737-0000+p3701-0000 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra234-p3740-0002+p3701-0008 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra234-p3768-0000+p3767-0000 := -@ > arch/arm64/boot/dts/nvidia/Makefile:DTC_FLAGS_tegra234-p3768-0000+p3767-0005 := -@ > arch/arm64/boot/dts/ti/Makefile:DTC_FLAGS_k3-am625-beagleplay += -@ > arch/arm64/boot/dts/ti/Makefile:DTC_FLAGS_k3-am625-sk += -@ > arch/arm64/boot/dts/ti/Makefile:DTC_FLAGS_k3-am62-lp-sk += -@ > arch/arm64/boot/dts/ti/Makefile:DTC_FLAGS_k3-am62a7-sk += -@ > arch/arm64/boot/dts/ti/Makefile:DTC_FLAGS_k3-am642-tqma64xxl-mbax4xxl += -@ > arch/arm64/boot/dts/ti/Makefile:DTC_FLAGS_k3-am6548-iot2050-advanced-m2 += -@ > arch/arm64/boot/dts/ti/Makefile:DTC_FLAGS_k3-j721e-common-proc-board += -@ > arch/arm64/boot/dts/ti/Makefile:DTC_FLAGS_k3-j721s2-common-proc-board += -@ > > > Are you saying that is NOT the way it should be done? Yeah, you miss DTB targets, so your overlay is not applied anywhere. Best regards, Krzysztof
