On 18/02/2024 6:52 p.m., Danila Tikhonov wrote:
You are referring to Dmitry Baryshkov, as I see. But Dmitry has already
reviewed my patch (message above).
Yes we previously debated and discussed verbatim copy of downstream
versus the format we used for 8150b.
The original driver I wrote for tcpm and the dts that went with it
derived from 4.19 where the interrupt definition was already right, so
in that case copy/paste of downstream is fine.
However with earlier kernels, 4.14 in this case the signalling isn't right.
Please read the discussion and reconsider your patch.
So it would be rude to change anything without his knowledge. Let's wait
for his answer
He'd have to be arguing against his own patch.....
One final nag - please use the kernel discussion format of bottom not
top posting.
https://git.codelinaro.org/bryan.odonoghue/kernel/-/blob/sc8280xp-v6.8-rc4-camss/Documentation/process/submitting-patches.rst?ref_type=heads
---
bod