Hi Paul, Thank you for the patch. On Fri, Feb 16, 2024 at 06:54:52PM +0900, Paul Elder wrote: > Add to the version enum an entry for the i.MX8MP ISP. > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> > --- > New in v12: > - split out from "media: rkisp1: Add match data for i.MX8MP ISP" > - changed the version enum name > --- > include/uapi/linux/rkisp1-config.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h > index 730673ecc63d..2d1c448a6ab8 100644 > --- a/include/uapi/linux/rkisp1-config.h > +++ b/include/uapi/linux/rkisp1-config.h > @@ -179,12 +179,14 @@ > * @RKISP1_V11: declared in the original vendor code, but not used > * @RKISP1_V12: used at least in rk3326 and px30 > * @RKISP1_V13: used at least in rk1808 > + * @RKISP1_V_IMX8MP: used in at least imx8mp We need to also update the comments that references version numbers in the same file. I'll send a v12.1 as a reply. > */ > enum rkisp1_cif_isp_version { > RKISP1_V10 = 10, > RKISP1_V11, > RKISP1_V12, > RKISP1_V13, > + RKISP1_V_IMX8MP, > }; > > enum rkisp1_cif_isp_histogram_mode { -- Regards, Laurent Pinchart