On 17/02/2024 14:14, Steven Niu wrote: > Document the Renesas RG3MxxB12A1 I3C HUB. > > Signed-off-by: Steven Niu <steven.niu.uj@xxxxxxxxxxx> > --- > .../devicetree/bindings/i3c/i3c-hub.yaml | 400 ++++++++++++++++++ > 1 file changed, 400 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i3c/i3c-hub.yaml > > diff --git a/Documentation/devicetree/bindings/i3c/i3c-hub.yaml b/Documentation/devicetree/bindings/i3c/i3c-hub.yaml > new file mode 100644 > index 000000000000..8ff6ca172975 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i3c/i3c-hub.yaml > @@ -0,0 +1,400 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i3c/i3c-hub.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: I3C HUB > + > +maintainers: > + - Zbigniew Lukwinski <zbigniew.lukwinski@xxxxxxxxxxxxxxx> > + - Steven Niu <steven.niu.uj@xxxxxxxxxxx> > + > +description: | > + I3C HUB is smart device which provides multiple functionality: > + * enabling voltage compatibility across I3C Controller and Target devices, > + * bus capacitance isolation > + * address conflict isolation > + * I3C port expansion > + * two controllers in a single I3C bus > + * I3C and SMBus device compatibility > + * GPIO expansion > + > + Having such big number of features, there is a need to have some DT knobs to tell the I3C HUB > + driver which features shall be enabled and how they shall be configured. I3C HUB driver read, > + validate DT knobs and set corresponding registers with the right way to satisfy user requests from > + DT. Ah, now I understand. Instead of doing proper schema for specific device, you want binding for generic driver. Sorry, that's a clear NAK and clear reason why Intel did not upstream this. Bindings are not for drivers. Bindings are for hardware. Describe specific device and that's it. Any non-device, but driver-related, property is NAKed. Best regards, Krzysztof
