Re: [PATCH v4 1/2] arm64: dts: qcom: ipq6018: add LDOA2 regulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 30, 2024 at 09:01:31PM +0800, Chukun Pan wrote:
> Add LDOA2 regulator of MP5496 to support SDCC voltage scaling.
> 
> Suggested-by: Robert Marko <robimarko@xxxxxxxxx>
> Signed-off-by: Chukun Pan <amadeus@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 5e1277fea725..322eced0b876 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -174,6 +174,11 @@ ipq6018_s2: s2 {
>  						regulator-max-microvolt = <1062500>;
>  						regulator-always-on;
>  					};
> +
> +					ipq6018_l2: l2 {

I still don't see a patch that does "something-supply = <&ipq6018_l2>;",
which would imply that the main thing this patch achieves is that the
regulator framework might turn the regulator off after a while.

Shouldn't there be a user of ipq6018_l2?

Regards,
Bjorn

> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <3300000>;
> +					};
>  				};
>  			};
>  		};
> -- 
> 2.25.1
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux