On 16/02/2024 07:30, Yang Xiwen wrote: > On 2/16/2024 10:09 AM, Rob Herring wrote: >> On Fri, 16 Feb 2024 07:48:56 +0800, Yang Xiwen wrote: >>> This binding gets rewritten. Compared to previous txt based binding doc, >>> the following changes are made: >>> >>> - No "hisi-femac-v1/2" binding anymore >>> - Remove unused Hi3516 SoC, add Hi3798MV200 >>> - add MDIO subnode >>> - add phy clock and reset >>> >>> Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/net/hisilicon-femac.yaml | 125 +++++++++++++++++++++ >>> 1 file changed, 125 insertions(+) >>> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Documentation/devicetree/bindings/net/hisilicon-femac.example.dtb: /example-0/ethernet@9c30000/mdio@1100: failed to match any schema with compatible: ['hisilicon,hisi-femac-mdio'] > it's fine. This compatible is documented in a plain text file > `./hisi-femac-mdio.txt`. No, it is not fine. This must be fixed. Best regards, Krzysztof
