Hi, On Thu, Feb 15, 2024 at 08:55:20AM -0600, Rob Herring wrote: > On Tue, Feb 13, 2024 at 02:00:55AM +0100, Sebastian Reichel wrote: > > Add compatibles used by different i.MX6 variants to the i.MX IOMUX > > Controller GPR binding. > > > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > > --- > > .../bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml > > index 1da1b758b4ae..8451cb4dd87c 100644 > > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml > > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml > > @@ -17,7 +17,23 @@ properties: > > compatible: > > oneOf: > > - items: > > - - const: fsl,imx8mq-iomuxc-gpr > > + - enum: > > + - fsl,imx6q-iomuxc-gpr > > + - fsl,imx8mq-iomuxc-gpr > > + - const: syscon > > + - const: simple-mfd > > + - items: > > + - enum: > > + - fsl,imx6sl-iomuxc-gpr > > + - fsl,imx6sll-iomuxc-gpr > > + - fsl,imx6ul-iomuxc-gpr > > + - const: fsl,imx6q-iomuxc-gpr > > + - const: syscon > > A bit odd that imx6q is a simple-mfd above, but not here. I suppose > that could be valid if the variants here don't have sub-devices or they > do, but have a dependency on the parent. These do not have sub-nodes, while the other instances have. > Acked-by: Rob Herring <robh@xxxxxxxxxx> Thanks, -- Sebastian