On Thu, Feb 15 2024 at 11:54, Marc Zyngier wrote:
> On Sat, 27 Jan 2024 16:17:32 +0000,
> Anup Patel <apatel@xxxxxxxxxxxxxxxx> wrote:
>> DOMAIN_BUS_PCI_DEVICE_IMS,
>> + DOMAIN_BUS_DEVICE_IMS,
>
> Only a personal taste, but since we keep calling it "device MSI",
> which it really is, I find it slightly odd to name the token
> "DEVICE_IMS".
>
> From what I understand, IMS is PCIe specific. Platform (and by
> extension device) MSI extends far beyond PCIe. So here, DEVICE_MSI
> would make a lot more sense and avoid confusion.
That's true, but I chose it intentionally because Interrupt Message
Store (IMS) is a (PCI) device specific way to store the message contrary
to PCI/MSI[-X] which has standardized storage.
So my thought was that this exactly reflects what the platform device
requires: device specific message store, aka DMS or DSMS :)
> But hey, I don't have much skin in this game, and I can probably
> mentally rotate the acronym...
I have no strong opinion about it though.
Thanks,
tglx
