On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > struct linedips embedds a small buffer for the string that we may reuse. > Update the driver accordingly. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Two nits below. > --- a/drivers/auxdisplay/ht16k33.c > +++ b/drivers/auxdisplay/ht16k33.c > @@ -451,8 +444,7 @@ static void ht16k33_seg14_update(struct work_struct *work) > > static int ht16k33_linedisp_get_map_type(struct linedisp *linedisp) > { > - struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, > - seg.linedisp); > + struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, linedisp); Please wrap long lines. > > switch (priv->type) { > case DISP_MATRIX: > @@ -471,8 +463,7 @@ static int ht16k33_linedisp_get_map_type(struct linedisp *linedisp) > > static void ht16k33_linedisp_update(struct linedisp *linedisp) > { > - struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, > - seg.linedisp); > + struct ht16k33_priv *priv = container_of(linedisp, struct ht16k33_priv, linedisp); Likewise. > > schedule_delayed_work(&priv->work, 0); > } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds