On Wed, 14 Feb 2024 16:06:06 +0000, "Arnd Bergmann" <arnd@xxxxxxxx> wrote: > > On Wed, Feb 14, 2024, at 10:52, Marc Zyngier wrote: > > On Tue, 13 Feb 2024 22:56:19 +0000, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > >> > >> diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig > >> --- a/drivers/of/Kconfig > >> +++ b/drivers/of/Kconfig > >> @@ -80,7 +80,8 @@ config OF_ADDRESS > >> > >> config OF_IRQ > >> def_bool y > >> - depends on !SPARC && IRQ_DOMAIN > >> + depends on !SPARC > >> + select IRQ_DOMAIN > > > > > > This seems to be moving is the right direction. > > Can we move the 'select IRQ_DOMAIN' under CONFIG_IRQCHIP > then and remove the individual selects from the irqchip > drivers? It looks like CONFIG_OF (other than sparc) now > unconditionally enables OF_IRQ and IRQCHIP anyway. As long as it also works ACPI, it should be OK. M. -- Without deviation from the norm, progress is not possible.