Re: [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote:
> Now that there is a dedicated compatible for the idendification page use
> that instead. This also allows the removal the size and pagesize
> properties.

This commit message fails to answer Why? 

And fails to mention the ABI break.

> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> index f6e422dc2663e..9d2328c185c90 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> @@ -122,10 +122,8 @@ eeprom1: eeprom@57 {
>  
>  	/* protectable identification memory (part of M24C64-D @57) */
>  	eeprom@5f {
> -		compatible = "st,24c64", "atmel,24c64";
> +		compatible = "atmel,24c64d-wl";

This compatible is not documented. Please add it to schema.

>  		reg = <0x5f>;
> -		size = <32>;
> -		pagesize = <32>;
>  		vcc-supply = <&reg_v3v3>;
>  	};
>  
> -- 
> 2.34.1
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux