On Mon, Feb 12, 2024 at 09:34:24AM +0100, Krzysztof Kozlowski wrote: > Examples of other nodes, like GPIO controller, are redundant and not > really needed in device bindings. ... > - i2c { > - #address-cells = <1>; > - #size-cells = <0>; > > - pcf8574: pcf8574@27 { > - compatible = "nxp,pcf8574"; > - reg = <0x27>; > - gpio-controller; > - #gpio-cells = <2>; > - }; > - }; In patch 3 you updated the lines that have lost their sense due to this one. And I agree with others, please leave this example in place. -- With Best Regards, Andy Shevchenko