On Thu, Feb 08, 2024 at 05:50:51PM +0000, Conor Dooley wrote: > On Thu, Feb 08, 2024 at 06:58:57PM +0200, Andy Shevchenko wrote: > > Add initial device tree documentation for Maxim MAX6958/6959. > > Why "initial"? Are there elements this display that you've not > documented yet? s/documented/implemented/ There are features of the hardware that may need additional properties. > > +title: MAX6958/6959 7-segment LED display controller with keyscan > > > +properties: > > + compatible: > > + const: maxim,max6959 > > Where's the max6958's compatible? I don't see it in your driver either. For now, see above, there is no need. Moreover, there is no need at all as we have autodetection mechanism. I don't see why we should have two compatible strings just for the sake of having them. > It seems that the max6959 has some interrupt capabilities that are not > available on the max6958, so a dedicated compatible seems suitable to > me. So, please clarify the DT's p.o.v. on the hardware that can be autodetected. Do we need to still have different compatible strings? What for? I don't see the need, sorry for my (silly) questions. -- With Best Regards, Andy Shevchenko
