On Tue, Jan 27, 2015 at 9:31 PM, Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote: > + if (of_find_property(np, "groups", NULL) || > + of_find_property(np, "pins", NULL)) { > + pmx->func_prop_name = "function"; > + pmx->groups_prop_name = "groups"; > + pmx->pins_prop_name = "pins"; > + } else { > + pmx->func_prop_name = "renesas,function"; > + pmx->groups_prop_name = "renesas,groups"; > + pmx->pins_prop_name = "renesas,pins"; > + } Do we want to be clever and save memory? pmx->func_prop_name = "renesas,function"; pmx->groups_prop_name = "renesas,groups"; pmx->pins_prop_name = "renesas,pins"; if (of_find_property(np, "groups", NULL) || of_find_property(np, "pins", NULL)) { pmx->func_prop_name += strlen("renesas,"); pmx->groups_prop_name += strlen("renesas,"); pmx->pins_prop_name += strlen("renesas,"); } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html