On Wed, Feb 7, 2024 at 4:09 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 07/02/2024 07:09, Jingbao Qiu wrote: > > Implement the PWM driver for CV1800. > > > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> > > --- > > > > + > > +static struct platform_driver cv1800_pwm_driver = { > > + .driver = { > > + .name = "cv1800-pwm", > > + .of_match_table = cv1800_pwm_dt_ids, > > + }, > > + .probe = cv1800_pwm_probe, > > +}; > > +module_platform_driver(cv1800_pwm_driver); > > + > > +MODULE_ALIAS("platform:cv1800-pwm"); > > You should not need MODULE_ALIAS() in normal cases. If you need it, > usually it means your device ID table is wrong (e.g. misses either > entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute > for incomplete ID table. > you're right, I will drop it. Best regards, Jingbao Qiu