On 06/02/2024 20:47, Eric Woudstra wrote: > The en8811h phy can be set with serdes polarity reversed on rx and/or tx. > > Changed from rfc patch: > > Explicitly say what -rx and -tx means. I don't know what does it mean. This is v1, so we don't expect changelog. If this is v2 (because there was RFC/RFT/RFkisses/RFhugs which are states of patchsets, not versions), then please mark it as v2 and put changelog under ---. > > Signed-off-by: Eric Woudstra <ericwouds@xxxxxxxxx> > --- > .../bindings/net/airoha,en8811h.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml > > diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml > new file mode 100644 > index 000000000000..99898e2bed64 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Airoha EN8811H PHY > + > +maintainers: > + - Eric Woudstra <ericwouds@xxxxxxxxx> > + > +description: > + Bindings for Airoha EN8811H PHY Drop "Bindings for" and instead describe the hardware. You are duplicating now title. > + > +allOf: > + - $ref: ethernet-phy.yaml# > + > +properties: This won't match to anything... missing compatible. You probably want to align with ongoing work on the lists. > + airoha,pnswap-rx: > + type: boolean > + description: > + Reverse rx polarity of the SERDES. This is the receiving > + side of the lines from the MAC towards the EN881H. > + > + Only one blank line. > + airoha,pnswap-tx: > + type: boolean > + description: > + Reverse tx polarity of SERDES. This is the transmitting > + side of the lines from EN8811H towards the MAC. > + > +unevaluatedProperties: false > + > +examples: > + - | > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy1: ethernet-phy@1 { > + reg = <1>; > + airoha,pnswap-rx; You have broken indentation. Use 4 spaces for example indentation. > + }; > + }; Best regards, Krzysztof
