On 2/6/2024 12:35 AM, Krzysztof Kozlowski wrote: > On 06/02/2024 08:15, Unnathi Chalicheemala wrote: >> Mapping Broadcast_AND region for LLCC in SM8450. > > Why? > > And why your DTS is in the middle of driver changes? Driver cannot > depend on DTS - you are now breaking all existing boards and users. > I was following a similar patch which has DT and driver changes in the same patchset: https://lore.kernel.org/all/20230314080443.64635-1-manivannan.sadhasivam@xxxxxxxxxx/ The AND region was added in the IP block in SM8450, but was not added to the DT or driver. That is why I included both in the same patchset - if you think the DT changes should be separate I can correct it in the next version. Thanks a lot for taking the time to review Krzysztof. > > Best regards, > Krzysztof >