On 06.02.24 16:35, Mark Brown wrote: > On Tue, Feb 06, 2024 at 04:05:15PM +0100, Javier Carrasco wrote: > >> The names in the datasheet are vdd for the 1V0 supply and vddio for the >> 3V3 supply. I named the latter vdd2 instead because this device does not >> have its own driver and instead it uses the onboard_usb_hub generic >> driver, where the supplies are named vdd and vdd2. > >> Those are the names used for devm_regulator_bulk_get(). Is that not the >> right way to match them? > > The binding should really use vddio instead of vdd2 but if that's an > existing binding then it gets more annoying, probably that existing > binding is wrong too since vddio does sound like an entirely plausible > standard name for a 3.3V supply. :/ At the very least the binding > should document the weird mapping, though ideally the driver would be > tought to request names matching the datasheet if the compatible is the > one for this device. Doing the better naming might be too much hassle > though. That is in line with my last reply, where the bindings I used as an example mention the real names of the supplies as they are defined in the datasheet. I can add that for the next version. Best regards, Javier Carrasco
