On Tue, 6 Feb 2024 at 13:41, Jagadeesh Kona <quic_jkona@xxxxxxxxxxx> wrote: > > Add support for the camera clock controller for camera clients to be > able to request for camcc clocks on SM8650 platform. > > Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx> > --- > drivers/clk/qcom/Kconfig | 8 + > drivers/clk/qcom/Makefile | 1 + > drivers/clk/qcom/camcc-sm8650.c | 3601 +++++++++++++++++++++++++++++++ > 3 files changed, 3610 insertions(+) > create mode 100644 drivers/clk/qcom/camcc-sm8650.c [ [skipped] > +static int __init cam_cc_sm8650_init(void) > +{ > + return platform_driver_register(&cam_cc_sm8650_driver); > +} > +subsys_initcall(cam_cc_sm8650_init); We have been here for the patch series for camcc-sm8550. Upstream reviewers expect that you don't repeat the same mistakes over and over again. Please use module_platform_driver(). > + > +static void __exit cam_cc_sm8650_exit(void) > +{ > + platform_driver_unregister(&cam_cc_sm8650_driver); > +} > +module_exit(cam_cc_sm8650_exit); > + > +MODULE_DESCRIPTION("QTI CAMCC SM8650 Driver"); > +MODULE_LICENSE("GPL"); > -- > 2.43.0 > > -- With best wishes Dmitry