On 2/6/24 11:04, Mark Brown wrote: > On Tue, Feb 06, 2024 at 10:12:30AM +0000, Peter Griffin wrote: > >> The patch ordering seems a bit off with this series..I believe it should be >> 1) dt-bindings patch (docs first) >> 2) Add the use_32bit_io flag / functionality >> 3) gs101 support (this patch) that uses the use_32bit_io functionality > > That's the ordering the series has? There's a random cleanup patch > tacked on the front but that really ought to be separate anyway. I put the include <linux/types.h> patch first because I considered it a fix (driver is using u32) and because I need types.h in patch 3/4. Fixes first, then bindings, then driver. Was I wrong?