Hi Krzysztof, On Tue, 6 Feb 2024 at 13:06, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 05/02/2024 15:00, Naresh Solanki wrote: > > Hi Krzysztof, > > > > > > On Mon, 5 Feb 2024 at 18:38, Krzysztof Kozlowski > > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> > >> On 05/02/2024 12:02, Naresh Solanki wrote: > >>> Driver expects regulator child node in upper case. > >>> Hence align with the same. > >> > >> Did the driver have DT support before? I think no, so why aligning that > >> way? I would argue that driver should be aligned with bindings, the > >> moment you add DT for the first time. > > Yes the driver has DT support already. > > This patch is to align with driver: > > https://github.com/torvalds/linux/blob/master/drivers/regulator/max5970-regulator.c#L381 > > That's not support for DT, but just naming regulators. I'm not sure if I get your perspective right & please correct me if I'm wrong, I'm just trying to adjust the dt binding of max5970 because found errors related to regulator child node SW0/SW1. Regulator driver expects to have regulators child nodes as SW0/1(upper case) But dt binding expects it to be lower case. Thus there is misalignment & due to which, when running CHECK_DTBS for my mainboard DTS, I see some errors. > > > > > It was aligned but I missed on case sensitivity. > > I don't see the alignment. Where did you align it? Which commit? The current patch is to address the regulators child node name with driver. Regards, Naresh > > > Driver expects it to be SW0/SW1 > > but DT had it as sw0/sw1. > > > Best regards, > Krzysztof >
