On January 21, 2015 16:07, Varka Bhadram wrote: > On Wednesday 21 January 2015 09:16 PM, Adam Thomson wrote: > > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > > > > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx> > > Reviewed-by: Hartmut Knaack <knaack.h@xxxxxx> > > Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx> > > (...) > > > + > > +static int da9150_gpadc_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct da9150 *da9150 = dev_get_drvdata(dev->parent); > > + struct da9150_gpadc *gpadc; > > + struct iio_dev *indio_dev; > > + int irq, ret; > > + > > + indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*gpadc)); > > You can directly use *dev* instead of *&pdev->dev* Yes agreed. Can follow up with change for this as it's not urgent and would rather leave current patch set as is. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f