Hi Lee Jones and Daniel,
On Wed, Jan 31, 2024 at 10:27 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
>
> Convert the da906{1,2} thermal device tree binding documentation to
> json-schema.
>
> Update MAINTAINERS entries and description by referring to
> dlg,da9062-thermal.yaml binding file.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
I missed adding Ack from Daniel[1] for v6 version. So adding here.
Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
[1] [v5,6/8] dt-bindings: thermal: Convert da906{1,2} thermal to
json-schema - Patchwork (kernel.org)
Cheers,
Biju
> Acked-by: Lee Jones <lee@xxxxxxxxxx>
> ---
> v6->v6 resend:
> * Added Ack from Lee Jones.
> v5->v6:
> * No change.
> v4->v5:
> * No change.
> v3->v4:
> * Restored the patch from v2.
> * Dropped example
> * Replaced enum->const for compatible property.
> * Added Rb tag from Rob and retained Rb tag as changes are trivial.
> v2->v3:
> * Fixed bot errors related to MAINTAINERS entry, invalid doc
> references and thermal examples by merging patch#4.
> v2:
> * New patch
> ---
> .../devicetree/bindings/mfd/da9062.txt | 2 +-
> .../bindings/thermal/da9062-thermal.txt | 36 -------------------
> .../bindings/thermal/dlg,da9062-thermal.yaml | 35 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 4 files changed, 37 insertions(+), 38 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/thermal/da9062-thermal.txt
> create mode 100644 Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt b/Documentation/devicetree/bindings/mfd/da9062.txt
> index 154c31fa4443..c8a7f119ac84 100644
> --- a/Documentation/devicetree/bindings/mfd/da9062.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9062.txt
> @@ -88,7 +88,7 @@ Sub-nodes:
>
> - watchdog: See ../watchdog/dlg,da9062-watchdog.yaml
>
> -- thermal : See ../thermal/da9062-thermal.txt
> +- thermal : See ../thermal/dlg,da9062-thermal.yaml
>
> Example:
>
> diff --git a/Documentation/devicetree/bindings/thermal/da9062-thermal.txt b/Documentation/devicetree/bindings/thermal/da9062-thermal.txt
> deleted file mode 100644
> index e241bb5a5584..000000000000
> --- a/Documentation/devicetree/bindings/thermal/da9062-thermal.txt
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -* Dialog DA9062/61 TJUNC Thermal Module
> -
> -This module is part of the DA9061/DA9062. For more details about entire
> -DA9062 and DA9061 chips see Documentation/devicetree/bindings/mfd/da9062.txt
> -
> -Junction temperature thermal module uses an interrupt signal to identify
> -high THERMAL_TRIP_HOT temperatures for the PMIC device.
> -
> -Required properties:
> -
> -- compatible: should be one of the following valid compatible string lines:
> - "dlg,da9061-thermal", "dlg,da9062-thermal"
> - "dlg,da9062-thermal"
> -
> -Optional properties:
> -
> -- polling-delay-passive : Specify the polling period, measured in
> - milliseconds, between thermal zone device update checks.
> -
> -Example: DA9062
> -
> - pmic0: da9062@58 {
> - thermal {
> - compatible = "dlg,da9062-thermal";
> - polling-delay-passive = <3000>;
> - };
> - };
> -
> -Example: DA9061 using a fall-back compatible for the DA9062 onkey driver
> -
> - pmic0: da9061@58 {
> - thermal {
> - compatible = "dlg,da9061-thermal", "dlg,da9062-thermal";
> - polling-delay-passive = <3000>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml b/Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml
> new file mode 100644
> index 000000000000..206635f74850
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/dlg,da9062-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dialog DA9062/61 TJUNC Thermal Module
> +
> +maintainers:
> + - Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> +
> +description: |
> + This module is part of the DA9061/DA9062. For more details about entire
> + DA9062 and DA9061 chips see Documentation/devicetree/bindings/mfd/da9062.txt
> +
> + Junction temperature thermal module uses an interrupt signal to identify
> + high THERMAL_TRIP_HOT temperatures for the PMIC device.
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: dlg,da9062-thermal
> + - items:
> + - const: dlg,da9061-thermal
> + - const: dlg,da9062-thermal
> +
> + polling-delay-passive:
> + description:
> + Specify the polling period, measured in milliseconds, between
> + thermal zone device update checks.
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2aab4f5d634a..f4a7bd8a1a04 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6171,7 +6171,7 @@ F: Documentation/devicetree/bindings/regulator/da92*.txt
> F: Documentation/devicetree/bindings/regulator/dlg,da9*.yaml
> F: Documentation/devicetree/bindings/regulator/dlg,slg51000.yaml
> F: Documentation/devicetree/bindings/sound/da[79]*.txt
> -F: Documentation/devicetree/bindings/thermal/da90??-thermal.txt
> +F: Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml
> F: Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> F: Documentation/hwmon/da90??.rst
> F: drivers/gpio/gpio-da90??.c
> --
> 2.39.2
>
