Re: [PATCH 2/2] of: property: use unsigned int return on of_graph_get_endpoint_count()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent

> > Because of of_graph_get_endpoint_count() doesn't report error,
> > just return count of endpoint, the return type should be unsigned.
> > Tidyup it.
> 
> I've briefly checked the callers and none of them seem to check if the
> return value is < 0. We may want to update them to store the returned
> value in an unsigned int variable, but that could be done separately.

Yes, it is one of my concern. This kind of change for example
"int vs unsigned int" / "pointer vs const pointer" might be big compile
warning/error. So I don't want to aggressive update it :(

Thank you for your review.

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux