Hi Laurent > > Because of of_graph_get_endpoint_count() doesn't report error, > > just return count of endpoint, the return type should be unsigned. > > Tidyup it. > > I've briefly checked the callers and none of them seem to check if the > return value is < 0. We may want to update them to store the returned > value in an unsigned int variable, but that could be done separately. Yes, it is one of my concern. This kind of change for example "int vs unsigned int" / "pointer vs const pointer" might be big compile warning/error. So I don't want to aggressive update it :( Thank you for your review. Best regards --- Renesas Electronics Ph.D. Kuninori Morimoto