Hi Rob, > > On Wed, Jan 31, 2024 at 07:43:18PM +0800, Xu Yang wrote: > > Add USB nodes on i.MX8ULP platform which has 2 USB controllers. > > > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> > > > > --- > > Changes in v2: > > - no changes > > Changes in v3: > > - no changes > > Changes in v4: > > - no changes > > Changes in v5: > > - no changes > > --- > > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 64 ++++++++++++++++++++++ > > 1 file changed, 64 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > index c4a0082f30d3..ead1f57e08ef 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > @@ -28,6 +28,8 @@ aliases { > > serial1 = &lpuart5; > > serial2 = &lpuart6; > > serial3 = &lpuart7; > > + usbphy0 = &usbphy1; > > + usbphy1 = &usbphy2; > > Drop these. We have no use for aliases to phys. Checked again. Yes, these two alias can be removed. > > > }; > > > > cpus { > > @@ -472,6 +474,68 @@ usdhc2: mmc@298f0000 { > > status = "disabled"; > > }; > > > > + usbotg1: usb@29900000 { > > + compatible = "fsl,imx8ulp-usb", "fsl,imx7ulp-usb", "fsl,imx6ul-usb"; > > + reg = <0x29900000 0x200>; > > + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&pcc4 IMX8ULP_CLK_USB0>; > > + power-domains = <&scmi_devpd IMX8ULP_PD_USB0>; > > + phys = <&usbphy1>; > > + fsl,usbmisc = <&usbmisc1 0>; > > + ahb-burst-config = <0x0>; > > + tx-burst-size-dword = <0x8>; > > + rx-burst-size-dword = <0x8>; > > + status = "disabled"; > > + }; > > + > > + usbmisc1: usbmisc@29900200 { > > + compatible = "fsl,imx8ulp-usbmisc", "fsl,imx7d-usbmisc", > > + "fsl,imx6q-usbmisc"; > > + #index-cells = <1>; > > Deprecated. Why are you using this? Do you mean "#index-cells"? We are using it all the time. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/tree/drivers/usb/chipidea/ci_hdrc_imx.c?h=linux-6.7.y#n137 Thanks, Xu Yang