On Fri, Feb 02, 2024 at 08:41:56AM +0100, Krzysztof Kozlowski wrote: > On 01/02/2024 16:17, Christian Marangi wrote: > > From: Robert Marko <robert.marko@xxxxxxxxxx> > > > > Add DT bindings defined for Qualcomm QCA807x PHY series related to > > calibration and DAC settings. > > Nothing from this file is used and your commit msg does not provide > rationale "why", thus it does not look like something for bindings. > Otherwise please point me which patch with *driver* uses these bindings. > Hi, since I have to squash this, I will include the reason in the schema patch. Anyway these are raw values used to configure the qcom,control-dac property. In the driver it's used by qca807x_config_init. We read what is set in DT and we configure the reg accordingly. If this is wrong should we use a more schema friendly approach with declaring an enum of string and document that there? > > > > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx> > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > > --- > > include/dt-bindings/net/qcom-qca807x.h | 30 ++++++++++++++++++++++++++ > > Use filename matching compatible, so vendor,device. No wildcards, unless > your compatible also has them. > > > 1 file changed, 30 insertions(+) > > create mode 100644 include/dt-bindings/net/qcom-qca807x.h > > > > > > Best regards, > Krzysztof > -- Ansuel
