On 02/02/2024 11:30, Anup Patel wrote:
>>> +int aplic_setup_priv(struct aplic_priv *priv, struct device *dev,
>>> + void __iomem *regs)
>>> +{
>>> + struct of_phandle_args parent;
>>> + int rc;
>>> +
>>> + /*
>>> + * Currently, only OF fwnode is supported so extend this
>>> + * function for ACPI support.
>>> + */
>>> + if (!is_of_node(dev->fwnode))
>>> + return -EINVAL;
>>> +
>>> + /* Save device pointer and register base */
>>> + priv->dev = dev;
>>> + priv->regs = regs;
>>> +
>>> + /* Find out number of interrupt sources */
>>> + rc = of_property_read_u32(to_of_node(dev->fwnode),
>>> + "riscv,num-sources",
>>> + &priv->nr_irqs);
>>
>> Use device_property_read_u32() which works for both ACPI and OF.
>
> In the previous versions, we did try to unify property reading for
> both ACPI and OF but MarcZ suggested to keep th ACPI and
> OF probe paths totally separate hence we use OF APIs over
> here because we should reach here only for OF probing.
Ok, indeed it makes sense. Discard that comment then !
Thanks,
Clément
