On Thu, Feb 01, 2024 at 04:17:34PM +0100, Christian Marangi wrote: > Generalize some qca808x LED functions in preparation for qca807x LED > support. > > The LED implementation of qca808x and qca807x is the same but qca807x > supports also Fiber port and have different hw control bits for Fiber > port. To limit code duplication introduce micro functions that takes reg > instead of LED index to tweak all the supported LED modes. Please could you split this up. Do the move first, no changes. Then add the macros and other refactoring. That will make this easier to review. Andrew
