On 31/01/2024 11:51, Svyatoslav Ryhel wrote:
> Add device-tree for LG Optimus Vu P895, which is a NVIDIA
> Tegra30-based smartphone, orignally running Android.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> ---
> arch/arm/boot/dts/nvidia/Makefile | 1 +
> arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts | 496 +++++
> arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi | 1821 ++++++++++++++++++
> 3 files changed, 2318 insertions(+)
> create mode 100644 arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts
> create mode 100644 arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi
>
> diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile
> index 60091bf7e48b..f66337e5d188 100644
> --- a/arch/arm/boot/dts/nvidia/Makefile
> +++ b/arch/arm/boot/dts/nvidia/Makefile
> @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_TEGRA_3x_SOC) += \
> tegra30-cardhu-a02.dtb \
> tegra30-cardhu-a04.dtb \
> tegra30-colibri-eval-v3.dtb \
> + tegra30-lg-p895.dtb \
> tegra30-ouya.dtb \
> tegra30-pegatron-chagall.dtb
> diff --git a/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts b/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts
> new file mode 100644
> index 000000000000..7e7cfaabe56e
> --- /dev/null
> +++ b/arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts
> @@ -0,0 +1,496 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/dts-v1/;
> +
> +#include "tegra30-lg-x3.dtsi"
> +
> +/ {
> + model = "LG Optimus Vu P895";
> + compatible = "lge,p895", "nvidia,tegra30";
This is lg, not lge.
Also, all over the file you have underscores in node names. They are not
allowed. Please consult DTS coding style document.
Best regards,
Krzysztof
