On Wed, Jan 31, 2024 at 09:41:15AM -0600, Bjorn Helgaas wrote: > Nit: could the subject line be more specific than "change arguments"? > E.g., something about collecting dw_pcie_prog_outbound_atu() arguments > in a struct? If you know that's the fundamental change, it's a lot > easier to read the commit log and the patch because you know the goal. How about "Consolidate arguments of dw_pcie_prog_outbound_atu() into a structure" Frank > > On Tue, Jan 30, 2024 at 07:45:27PM -0500, Frank Li wrote: > > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > > > This is a preparation before adding the Msg-type outbound iATU > > mapping. The respective update will require two more arguments added > > to __dw_pcie_prog_outbound_atu(). That will make the already > > complicated function prototype even more hard to comprehend accepting > > _eight_ arguments. In order to prevent that and keep the code > > more-or-less readable all the outbound iATU-related arguments are > > moved to the new config-structure: struct dw_pcie_ob_atu_cfg pointer > > to which shall be passed to dw_pcie_prog_outbound_atu(). The structure > > is supposed to be locally defined and populated with the outbound iATU > > settings implied by the caller context. > > > > As a result of the denoted change there is no longer need in having > > the two distinctive methods for the Host and End-point outbound iATU > > setups since the corresponding code can directly call the > > dw_pcie_prog_outbound_atu() method with the config-structure > > populated. Thus dw_pcie_prog_ep_outbound_atu() is dropped. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > Reviewed-by: Serge Semin <fancer.lancer@xxxxxxxxx> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > > ...
