On 19/01/2024 10:24, Mao Jinlong wrote: > Add coresight components on Qualcomm SM8450 Soc. The components include > TMC ETF/ETR, ETE, STM, TPDM, CTI. > > Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx> > --- > + funnel@13810000 { > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > + > + reg = <0x0 0x13810000 0x0 0x1000>; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + in-ports { > + > + port { > + funnel_apss_in_funnel_ete: endpoint { > + remote-endpoint = > + <&funnel_ete_out_funnel_apss>; > + }; > + }; > + > + }; > + > + out-ports { > + port { > + funnel_apss_out_funnel_in1: endpoint { > + remote-endpoint = > + <&funnel_in1_in_funnel_apss>; > + }; > + }; > + You have several redundant lines, everywhere. Clean up to match coding style. There is no blank line between trailing }; and another trailing };. > + }; > + }; Best regards, Krzysztof