On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote:
> Most Rockchip hdmi nodes are part of a power domain.
> Add a power-domains property.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Fix example.
Just a note, in the future please explain why simply reordering the
properties constitutes "fixing" the example. I figure your intention is
to align with the (new) documentation about property ordering.
Thanks,
Conor.
>
> Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx>
> ---
> .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index cd0a42f35f24..6f421740b613 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -94,6 +94,9 @@ properties:
> - const: default
> - const: unwedge
>
> + power-domains:
> + maxItems: 1
> +
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> @@ -141,16 +144,18 @@ examples:
> #include <dt-bindings/clock/rk3288-cru.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/power/rk3288-power.h>
>
> hdmi: hdmi@ff980000 {
> compatible = "rockchip,rk3288-dw-hdmi";
> reg = <0xff980000 0x20000>;
> - reg-io-width = <4>;
> - ddc-i2c-bus = <&i2c5>;
> - rockchip,grf = <&grf>;
> interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cru PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>;
> clock-names = "iahb", "isfr";
> + ddc-i2c-bus = <&i2c5>;
> + power-domains = <&power RK3288_PD_VIO>;
> + reg-io-width = <4>;
> + rockchip,grf = <&grf>;
>
> ports {
> #address-cells = <1>;
> --
> 2.39.2
>
>
Attachment:
signature.asc
Description: PGP signature
