RE: [PATCH v2 4/5] arm64: dts: renesas: rzg2ul-smarc: Enable CRU, CSI support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Tuesday, January 30, 2024 4:17 PM
> Subject: Re: [PATCH v2 4/5] arm64: dts: renesas: rzg2ul-smarc: Enable CRU,
> CSI support
> 
> Hi Biju,
> 
> On Fri, Jan 26, 2024 at 2:31 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Enable CRU, CSI on RZ/G2UL SMARC EVK and tie the CSI to the OV5645
> > sensor using Device Tree overlay.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/Makefile
> > +++ b/arch/arm64/boot/dts/renesas/Makefile
> > @@ -104,6 +104,8 @@ dtb-$(CONFIG_ARCH_R8A77965) +=
> > r8a779m5-salvator-xs-panel-aa104xd12.dtb
> >
> >  dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc.dtb
> >  dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043-smarc-pmod.dtbo
> 
> Missing
> 
>     dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc-cru-csi-ov5645.dtbo

OK, will add this in next version.

Cheers,
Biju
> 
> so r9a07g043u11-smarc-cru-csi-ov5645.dtbo is retained for separate use?
> 
> > +r9a07g043u11-smarc-cru-csi-ov5645-dtbs := r9a07g043u11-smarc.dtb
> > +r9a07g043u11-smarc-cru-csi-ov5645.dtbo
> > +dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc-cru-csi-ov5645.dtb
> >  r9a07g043u11-smarc-pmod-dtbs := r9a07g043u11-smarc.dtb
> > r9a07g043-smarc-pmod.dtbo
> >  dtb-$(CONFIG_ARCH_R9A07G043) += r9a07g043u11-smarc-pmod.dtb
> 
> The rest LGTM.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux