On 1/30/24 09:31, André Draszik wrote: > On Mon, 2024-01-29 at 13:16 -0600, Sam Protsenko wrote: >> That sounds reasonable. But I wonder if that bit (about making this >> clock CLK_IS_CRITICAL to make earlycon functional) can be documented >> somewhere. Perhaps in the serial driver (earlycon function), or >> somewhere in device tree bindings? Because otherwise it might remain >> an arcane knowledge and people won't be able to use earlycon later. >> Anyways, for this patch: >> >> Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx> >> >> and if you think it makes sense to document the bit above, please do. > > Will do on top of > https://lore.kernel.org/all/20240119104526.1221243-6-tudor.ambarus@xxxxxxxxxx/ > once that is in. > It was applied, it's in linux-next. I like the dt bindings idea, it's the first thing I check when dealing with new hardware. No idea though how to add comments just for a specific compatible. Shall be a description somewhere...