On Mon, Jan 29, 2024 at 09:59:03PM +0800, Jie Luo wrote: > > > On 1/27/2024 1:33 AM, Christian Marangi wrote: > > On Fri, Jan 26, 2024 at 07:20:03PM +0200, Dmitry Baryshkov wrote: > > > On Fri, 26 Jan 2024 at 18:03, Jie Luo <quic_luoj@xxxxxxxxxxx> wrote: > > > > > > > > > > > > > > > > On 1/26/2024 1:18 AM, Andrew Lunn wrote: > > > > > > Hi Christian, > > > > > > Just a gentle reminder. > > > > > > > > > > > > The MDIO frequency config is already added by the following patch series. > > > > > > https://lore.kernel.org/netdev/28c8b31c-8dcb-4a19-9084-22c77a74b9a1@xxxxxxxxxx/T/#m840cb8d269dca133c3ad3da3d112c63382ec2058 > > > > > > > > > > I admit this version was posted first. However, its embedded in a > > > > > patch series which is not making much progress, and i doubt will make > > > > > progress any time soon. > > > > > > > > > > If you really want your version to be used, please split it out into a > > > > > standalone patch series adding just MDIO clock-frequency support, with > > > > > its binding, and nothing else. > > > > > > > > > > Andrew > > > > > > > > Hi Andrew, > > > > We will rework the patch series to include only MDIO frequency related > > > > function and frequency dt binding, and post the updated patch series > > > > on th/Tuesdae Mondayy of next week. We will work with Christian to > > > > ensure he can re-use this patch as well. > > > > > > Can you do the other way around: rebase your patches on top of Chritian's work? > > Hi Dmitry, > Sure, we can take this approach if fine by Andrew as well. > > > > > > > > Would be ideal, also I have to send v2 that handle the 802.3 suggested > > MDC rate (ready I just need to send after this has been handled). > > > > Also I can see some problem with Lui patch where thse divior > > value is not reapplied after MDIO reset effectively reverting to the > > default value. > > Hi Christian, > In my version, the divisor is programmed in every MDIO operation and hence I > did not add the code to revert to configured value in reset function. But > sure. we can program it once during the probe/reset and avoid doing it > during read/write ops. > > In addition, the MDIO divisor 1, 2 and 4 are not supported by the MDIO > hardware block, maybe we can remove these macros to avoid confusion, or add > a comment mentioning that these are not supported. > Hi, thanks for confirming it! In v2 I already changed the logic to start looping from divisor 8 and added comments in DT and driver about not assuring correct funcionality with those divisor. > > > > If it's a credits problem I can totally change the from or add > > Co-devloped, I just need the feature since the thing is broken from a > > looong time on ipq40xx and ipq807x. > > -- Ansuel
