Hi Krzysztof, On 1/29/24 10:26, Krzysztof Kozlowski wrote: > On 26/01/2024 20:13, Cristian Ciocaltea wrote: >> The Synopsys DesignWare MAC found on StarFive JH7100 SoC is mostly >> similar to the newer JH7110, but it requires only two interrupts and a >> single reset line, which is 'ahb' instead of the commonly used >> 'stmmaceth'. >> >> Since the common binding 'snps,dwmac' allows selecting 'ahb' only in >> conjunction with 'stmmaceth', extend the logic to also permit exclusive >> usage of the 'ahb' reset name. This ensures the following use cases are >> supported: >> >> JH7110: reset-names = "stmmaceth", "ahb"; >> JH7100: reset-names = "ahb"; >> other: reset-names = "stmmaceth"; > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Thank you for the review! Could you please apply it to the RESEND version [1] instead, as this one had an issue collecting the latest tags, as indicated in [2]. Regards, Cristian [1] https://lore.kernel.org/lkml/20240126192128.1210579-2-cristian.ciocaltea@xxxxxxxxxxxxx/ [2] https://lore.kernel.org/lkml/920e764c-4fa3-4298-bb49-d31416fc3dd6@xxxxxxxxxxxxx/
