Hi Christophe, On Mon, Dec 08, 2014 at 10:08:12PM +0100, Christophe Ricard wrote: > We are usually sending a response to a command received from a known pipe. > Keep this information as is. > > Signed-off-by: Christophe Ricard <christophe-h.ricard@xxxxxx> > --- > include/net/nfc/hci.h | 2 +- > net/nfc/hci/command.c | 7 +------ > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/include/net/nfc/hci.h b/include/net/nfc/hci.h > index c1c644b..6f11ca2 100644 > --- a/include/net/nfc/hci.h > +++ b/include/net/nfc/hci.h > @@ -260,7 +260,7 @@ int nfc_hci_send_cmd(struct nfc_hci_dev *hdev, u8 gate, u8 cmd, > int nfc_hci_send_cmd_async(struct nfc_hci_dev *hdev, u8 gate, u8 cmd, > const u8 *param, size_t param_len, > data_exchange_cb_t cb, void *cb_context); > -int nfc_hci_send_response(struct nfc_hci_dev *hdev, u8 gate, u8 response, > +int nfc_hci_send_response(struct nfc_hci_dev *hdev, u8 pipe, u8 response, > const u8 *param, size_t param_len); This makes this API a bit odd, as all other routines there take a gate as an input. Instead of changing the prototype, could you please remove that routine and have the callers (which is nfc_hci_cmd_received only) call nfc_hci_hcp_message_tx directly ? Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
