Re: [PATCH] dt-bindings: mmp-dma: convert to YAML

[Conor Dooley <conor@xxxxxxxxxx>]

Hey,

On Sat, Jan 27, 2024 at 05:53:45PM +0100, Duje Mihanović wrote:
> Convert the Marvell MMP DMA binding to YAML.
> 
> The TXT binding mentions that the controller may have one IRQ per DMA
> channel. Examples of this were dropped in the YAML binding because of
> dt_binding_check complaints (either too many interrupt cells or
> interrupts) and the fact that this is not used in any of the in-tree
> device trees.
> 
> Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx>
> ---
>  .../devicetree/bindings/dma/marvell,mmp-dma.yaml   | 82 ++++++++++++++++++++++
>  Documentation/devicetree/bindings/dma/mmp-dma.txt  | 81 ---------------------
>  2 files changed, 82 insertions(+), 81 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/marvell,mmp-dma.yaml b/Documentation/devicetree/bindings/dma/marvell,mmp-dma.yaml
> new file mode 100644
> index 000000000000..fe94ba9143e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/marvell,mmp-dma.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/marvell,mmp-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell MMP DMA controller
> +
> +maintainers:
> +  - Duje Mihanović <duje.mihanovic@xxxxxxxx>
> +
> +description:
> +  Marvell MMP SoCs may have two types of DMA controllers, peripheral and audio.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - marvell,pdma-1.0
> +      - marvell,adma-1.0
> +      - marvell,pxa910-squ
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description:
> +      Interrupt lines for the controller, may be shared or one per DMA channel
> +    minItems: 1
> +
> +  '#dma-channels':
> +    deprecated: true
> +
> +  '#dma-requests':
> +    deprecated: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - '#dma-cells'
> +
> +allOf:
> +  - $ref: dma-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - marvell,adma-1.0
> +              - marvell,pxa910-squ
> +    then:
> +      properties:
> +        asram:
> +          description:
> +            phandle to the SRAM pool
> +          minItems: 1
> +          maxItems: 1
> +        iram:
> +          maxItems: 

These properties are not mentioned in the text binding, nor commit
message. Where did they come from?

That said, for properties that are only usable on some platforms, please
define them at the top level and conditionally permit/constrain them.

> +unevaluatedProperties: false
> +
> +examples:
> +  # Peripheral controller
> +  - |
> +    pdma0: dma-controller@d4000000 {

The label is not needed here or below.
In fact, I'd probably delete the second example as it shows nothing that
the first one does not.

thanks,
Conor.

> +        compatible = "marvell,pdma-1.0";
> +        reg = <0xd4000000 0x10000>;
> +        interrupts = <47>;
> +        #dma-cells = <2>;
> +        dma-channels = <16>;
> +    };
> +
> +  # Audio controller
> +  - |
> +    squ: dma-controller@d42a0800 {
> +        compatible = "marvell,pxa910-squ";
> +        reg = <0xd42a0800 0x100>;
> +        interrupts = <46>;
> +        #dma-cells = <2>;
> +        dma-channels = <2>;
> +    };

Attachment: signature.asc
Description: PGP signature