Hi Linus, > Subject: Re: [PATCH v2 4/6] pinctrl: Implementation of the generic scmi- > pinctrl driver > > Hi Peng, > > thanks for your patch! > > On Thu, Jan 4, 2024 at 11:45 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> > wrote: > > > From: Peng Fan <peng.fan@xxxxxxx> > > > > scmi-pinctrl driver implements pinctrl driver interface and using SCMI > > protocol to redirect messages from pinctrl subsystem SDK to SCMI > > platform firmware, which does the changes in HW. > > > > Co-developed-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx> > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > (...) > > +#ifdef CONFIG_OF > > + .dt_node_to_map = pinconf_generic_dt_node_to_map_all, > > + .dt_free_map = pinconf_generic_dt_free_map, #endif > > This looks like with !OF the driver becomes pretty unusable doesn't it? > > Should we just depend on OF in Kconfig or are there already plans for ACPI or > similar? I not have platforms that has ACPI support. Cristian, Sudeep do you have plans? I could add depends on OF in V4, since current patch version is https://lore.kernel.org/all/20240121-pinctrl-scmi-v3-4-8d94ba79dca8@xxxxxxx/ or I could use a follow up patch after V4 patch 1-4 applied. Would you ACK the current V3 patch or wait I add OF dependency? Thanks, Peng. > > Yours, > Linus Walleij
