Hi Peng, thanks for your patch! On Sun, Jan 21, 2024 at 11:18 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote: > -obj-$(CONFIG_PINCTRL_SCMI) += pinctrl-scmi.o > +obj-$(CONFIG_PINCTRL_SCMI) += pinctrl-scmi.o pinctrl-scmi-imx.o I think you should probably create a sub-Kconfig option for this file. Yours, Linus Walleij