On Thu 2024-01-25 @ 09:12:46 PM, Heiko Stuebner wrote: > Hi, > > Am Freitag, 19. Januar 2024, 00:03:12 CET schrieb Trevor Woerner: > > On Thu 2024-01-18 @ 08:31:30 AM, Jonas Karlman wrote: > > > On 2024-01-17 09:15, Jonas Karlman wrote: > > > I have just sent out a U-Boot series that fix ethernet on the v1.21 > > > revision of the ROCK Pi E board, see [2]. > > > > Thank you! I have tested your patches both in U-Boot and Linux and they work > > perfectly. > > if I'm reading this correctly, this patch is not needed anymore, right? True, patch 2/2 is not needed (or correct). > I'm not yet sure about the first patch, as it really is > just a cosmetic ;-) I wouldn't say it's entirely cosmetic. Some rock-pi-e boards come with the 8211e PHY and others come with the 8211f PHY. Labelling the phandle as "rtl8211e" would be misleading/confusing for people who had boards whose boot logs would report otherwise.
