On Sat, 27 Jan 2024 01:36:34 +0800 rohan.g.thomas@xxxxxxxxx wrote: > > The tricky part here is that the whole devicetree bindings story for the > > stmmac driver is filled with such configuration choices. As such, it is > > only natural to add the property you are suggesting here. I completely > > agree. But you can also argue that it is "wrong", because it does not > > just describe the hardware, but also a configuration choice. > > Isn't this requirement of using enhanced tx desc instead of normal tx > desc to support TBS is specific to Synopsys IP? Switching from > normal desc to enhanced desc at the time of tc-etf qdisc offload > cannot be done without traffic disruption, which I don't think is > acceptable. Since this behavior is IP specific, can we consider > this as an OS configuration choice? Why is traffic disruption not acceptable when TBS gets turned on? User has to install the right qdisc to enable TBS, I presume, installing qdiscs destroys the old ones which also leads to packet drops.
