On Fri, Jan 26, 2024 at 05:16:14PM +0530, Naresh Solanki wrote:
> Add regulator-compatible property.
Why? I can see that this is what you did, but there's no justification
for it.
grepping for this property, the first thing I see is:
rg "regulator-compatible"
drivers/regulator/of_regulator.c
389: * based on either the deprecated property regulator-compatible if present,
428: "regulator-compatible", NULL);
486: name = of_get_property(child, "regulator-compatible", NULL);
The property is deprecated, so you'll need twice as good a justification
for adding it!
> Also update example.
>
> TEST=Run below command & make sure there is no error
> make DT_CHECKER_FLAGS=-m dt_binding_check
Same comment here as my other mail.
Thanks,
Conor.
>
> Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mfd/maxim,max5970.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml b/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml
> index 0da5cae3852e..75175098cbc2 100644
> --- a/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max5970.yaml
> @@ -74,6 +74,9 @@ properties:
> description: |
> The value of current sense resistor in microohms.
>
> + regulator-compatible:
> + pattern: "^SW[0-1]$"
> +
> required:
> - shunt-resistor-micro-ohms
>
> @@ -111,6 +114,8 @@ examples:
>
> regulators {
> sw0_ref_0: sw0 {
> + regulator-compatible = "SW0";
> + regulator-name = "p5v";
> shunt-resistor-micro-ohms = <12000>;
> };
> };
> @@ -145,9 +150,13 @@ examples:
>
> regulators {
> sw0_ref_1: sw0 {
> + regulator-compatible = "SW0";
> + regulator-name = "p5v_aux";
> shunt-resistor-micro-ohms = <12000>;
> };
> sw1_ref_1: sw1 {
> + regulator-compatible = "SW1";
> + regulator-name = "p3v3_aux";
> shunt-resistor-micro-ohms = <10000>;
> };
> };
>
> base-commit: ecb1b8288dc7ccbdcb3b9df005fa1c0e0c0388a7
> --
> 2.42.0
>
Attachment:
signature.asc
Description: PGP signature
