On Thu, Jan 25, 2024 at 07:55:14PM -0800, Bjorn Andersson wrote:
> The failing read-test in __i2c_hid_core_probe() determines that there's
> nothing connected at the documented address of the touchscreen.
>
> Introduce the 5ms after-power and 200ms after-reset delays found in the
> ACPI tables. Also wire up the reset-gpio, for good measure.
As the supplies for the touchscreen are always on (and left on by the
bootloader) it would seem that it is really the addition of the reset
gpio which makes things work here. Unless the delay is needed for some
other reason.
(The power-on delay also looks a bit short compared to what is used for
other devices.)
Reset support was only recently added with commit 2be404486c05 ("HID:
i2c-hid-of: Add reset GPIO support to i2c-hid-of") so we should not
backport this one before first determining that.
That commit also added a comment in the HID driver about the
'post-reset-deassert-delay-ms' to the driver which should now be
removed:
/*
* Note this is a kernel internal device-property set by x86 platform code,
* this MUST not be used in devicetree files without first adding it to
* the DT bindings.
*/
Johan
