Hello, On Thu, Jan 25, 2024 at 10:55:28AM +0800, Wenhua Lin wrote: > The PMW unit on the current Unisoc's SoCs has 4 channels but has different > address offsets. On UMS512, they are 0x0, 0x20, 0x40, 0x60 respectively, > while are 0x0, 0x4000, 0x8000, 0xC000 on UMS9620. I just sent feedback to (implicit) v1 of this patch and only realized now there is a v2 already. My feedback given there also applies to this patch. So I'm marking also this patch as "changes requested" in patchwork, please look at https://lore.kernel.org/linux-pwm/bvnhi4qeczrmlmaog6drlztg4x6ubozjzu57sukpejme7xecqc@724g62vjgxrq/T/#u for the details. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
